Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: navigation manager #177

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Oct 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #177 (89d5587) into main (77f3dcf) will increase coverage by 0.11%.
The diff coverage is 93.18%.

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   89.17%   89.28%   +0.11%     
==========================================
  Files          61       63       +2     
  Lines        1496     1540      +44     
  Branches      234      245      +11     
==========================================
+ Hits         1334     1375      +41     
- Misses        125      126       +1     
- Partials       37       39       +2     
Flag Coverage Δ
e2e-1 63.78% <ø> (ø)
e2e-2 40.63% <ø> (ø)
e2e-4 66.44% <ø> (ø)
e2e-5 50.19% <ø> (ø)
e2e-7 59.15% <ø> (ø)
e2e-8 58.33% <ø> (ø)
unit 91.59% <93.18%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/lib/services/navManager.ts 97.05% <97.05%> (ø)
core/lib/services/sortUtils.ts 80.00% <80.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@divdavem divdavem marked this pull request as ready for review October 6, 2023 13:35
@fbasso fbasso self-requested a review October 6, 2023 14:01
Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @divdavem !

@divdavem
Copy link
Member Author

divdavem commented Oct 6, 2023

@fbasso Thank you for your review!

@divdavem divdavem merged commit f36bcde into AmadeusITGroup:main Oct 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants