Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run core outside of Angular zone #188

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

divdavem
Copy link
Member

No description provided.

@divdavem divdavem changed the title feat: run core outside of Angular zone [WIP] feat: run core outside of Angular zone Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #188 (e0d0d3e) into main (07d66a9) will decrease coverage by 0.28%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   90.00%   89.72%   -0.28%     
==========================================
  Files          34       65      +31     
  Lines        1200     1762     +562     
  Branches      218      287      +69     
==========================================
+ Hits         1080     1581     +501     
- Misses         83      131      +48     
- Partials       37       50      +13     
Flag Coverage Δ
e2e-1 56.35% <77.58%> (?)
e2e-2 48.71% <71.92%> (?)
e2e-4 66.44% <ø> (?)
e2e-5 50.19% <ø> (?)
e2e-7 66.43% <ø> (?)
e2e-8 54.61% <ø> (?)
unit 90.36% <83.67%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
angular/lib/src/lib/alert/alert.component.ts 84.21% <100.00%> (ø)
angular/lib/src/lib/modal/modal.component.ts 76.66% <100.00%> (ø)
...lar/lib/src/lib/pagination/pagination.component.ts 58.33% <100.00%> (ø)
...r/lib/src/lib/progressbar/progressbar.component.ts 90.90% <100.00%> (ø)
angular/lib/src/lib/rating/rating.component.ts 95.65% <100.00%> (ø)
angular/lib/src/lib/select/select.component.ts 100.00% <100.00%> (ø)
angular/lib/src/lib/slider/slider.component.ts 92.85% <100.00%> (ø)
...gular/lib/src/lib/accordion/accordion.component.ts 4.54% <0.00%> (ø)
angular/headless/src/lib/utils.ts 87.67% <83.67%> (+79.97%) ⬆️

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@divdavem divdavem force-pushed the runCoreOutsideNgZone branch 7 times, most recently from ba81e5a to 90d09a3 Compare October 24, 2023 12:41
@divdavem divdavem changed the title [WIP] feat: run core outside of Angular zone feat: run core outside of Angular zone Oct 24, 2023
@divdavem divdavem marked this pull request as ready for review October 24, 2023 15:06
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@quentinderoubaix quentinderoubaix merged commit 24d49aa into AmadeusITGroup:main Oct 24, 2023
11 of 13 checks passed
@divdavem
Copy link
Member Author

@quentinderoubaix Thank you for reviewing and merging my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants