Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal props validation #275

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Dec 1, 2023

No description provided.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9c14c0a) 92.19% compared to head (ddb4da8) 92.17%.

Files Patch % Lines
core/lib/modal/modal.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   92.19%   92.17%   -0.02%     
==========================================
  Files          70       70              
  Lines        1934     1943       +9     
  Branches      341      343       +2     
==========================================
+ Hits         1783     1791       +8     
  Misses         87       87              
- Partials       64       65       +1     
Flag Coverage Δ
e2e-1 74.83% <92.85%> (+0.08%) ⬆️
e2e-2 61.37% <64.28%> (+0.47%) ⬆️
e2e-4 74.33% <71.42%> (+0.02%) ⬆️
e2e-5 69.67% <71.42%> (+0.05%) ⬆️
e2e-7 63.80% <92.85%> (+0.18%) ⬆️
e2e-8 71.14% <92.85%> (+0.13%) ⬆️
unit 92.38% <71.42%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divdavem divdavem marked this pull request as ready for review December 1, 2023 13:50
Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me :)

@divdavem
Copy link
Member Author

divdavem commented Dec 1, 2023

@fbasso Thank you for your review!

@divdavem divdavem merged commit eba66fb into AmadeusITGroup:main Dec 1, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants