Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): useDirectives #311

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

divdavem
Copy link
Member

No description provided.

@divdavem divdavem requested a review from fbasso December 13, 2023 09:58
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (142ae61) 91.97% compared to head (944ecba) 91.72%.

Files Patch % Lines
react/headless/src/utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   91.97%   91.72%   -0.26%     
==========================================
  Files          36       74      +38     
  Lines        1271     2078     +807     
  Branches      241      369     +128     
==========================================
+ Hits         1169     1906     +737     
- Misses         65      102      +37     
- Partials       37       70      +33     
Flag Coverage Δ
e2e-1 61.83% <ø> (?)
e2e-2 56.03% <ø> (?)
e2e-4 68.91% <0.00%> (?)
e2e-5 67.37% <0.00%> (?)
e2e-7 55.28% <ø> (?)
e2e-8 75.78% <ø> (?)
unit 91.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @divdavem !

@divdavem
Copy link
Member Author

@fbasso Thank you for your review!

@divdavem divdavem merged commit 4e25c1a into AmadeusITGroup:main Dec 13, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants