Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: landing page on mobile #35 #36

Conversation

quentinderoubaix
Copy link
Contributor

Making the display slightly better on mobile, by replacing the Work In Progress by an icon on small width devices + handling our menu layout better in other pages.

@quentinderoubaix quentinderoubaix linked an issue Jul 29, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #36 (cfb5224) into main (4045c82) will decrease coverage by 1.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   85.32%   83.49%   -1.83%     
==========================================
  Files          60       60              
  Lines        1785     1818      +33     
  Branches      359      362       +3     
==========================================
- Hits         1523     1518       -5     
- Misses        211      251      +40     
+ Partials       51       49       -2     
Flag Coverage Δ
e2e-1 70.57% <ø> (ø)
e2e-10 77.11% <ø> (ø)
e2e-2 81.91% <ø> (?)
e2e-3 81.91% <ø> (ø)
e2e-4 52.33% <ø> (-0.41%) ⬇️
e2e-5 80.41% <ø> (ø)
e2e-6 80.41% <ø> (ø)
e2e-7 73.23% <ø> (ø)
e2e-8 77.01% <ø> (ø)
e2e-9 66.18% <ø> (ø)
unit 93.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@divdavem divdavem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for your PR!

@quentinderoubaix quentinderoubaix merged commit 509b90e into AmadeusITGroup:main Jul 31, 2023
@quentinderoubaix quentinderoubaix deleted the 35-fix-landing-page-display-on-mobile branch July 31, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix landing page display on mobile
2 participants