Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doc + slight display improvements #82

Conversation

quentinderoubaix
Copy link
Contributor

  • added some paragraphs for the samples
  • resizable observer now observes the root element instead of the body
  • slight display improvements on the alert icon + pagination sample for 400px (requirement for full accessibility)

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #82 (a458de4) into main (44be31d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          69       69           
  Lines        5237     5237           
  Branches      460      460           
=======================================
  Hits         4923     4923           
  Misses        267      267           
  Partials       47       47           
Flag Coverage Δ
e2e-1 65.06% <ø> (ø)
e2e-2 18.16% <ø> (ø)
e2e-4 73.80% <ø> (ø)
e2e-5 47.61% <ø> (ø)
e2e-7 52.61% <ø> (ø)
e2e-8 31.04% <ø> (ø)
unit 98.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
angular/lib/src/lib/alert/alert.component.ts 90.90% <ø> (ø)
core/lib/alert.ts 98.95% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@quentinderoubaix quentinderoubaix force-pushed the documentation-and-display-improvements branch 4 times, most recently from 2295ae6 to f35ea3a Compare August 16, 2023 15:12
@quentinderoubaix quentinderoubaix force-pushed the documentation-and-display-improvements branch from f35ea3a to a458de4 Compare August 16, 2023 19:26
@quentinderoubaix quentinderoubaix merged commit 4c71c4a into AmadeusITGroup:main Aug 17, 2023
13 checks passed
@quentinderoubaix
Copy link
Contributor Author

thanks for the review @ExFlo !

@quentinderoubaix quentinderoubaix deleted the documentation-and-display-improvements branch August 17, 2023 09:30
@divdavem
Copy link
Member

divdavem commented Aug 18, 2023

@quentinderoubaix Why did you remove the service worker?
Now, because of this, browsers that visited the site before the removal of the service worker are now always showing the old version of the site.
I am adding it back in #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants