Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]S08_ContractCheck示例代码中增加 GoodContractCheck 的示例 #792

Closed
1 task done
andOneBasketball opened this issue Sep 28, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@andOneBasketball
Copy link

Details(细节)

https://github.com/AmazingAng/WTF-Solidity/blob/main/S08_ContractCheck/ContractCheck.sol 中仅有漏洞合约的展示。虽然https://www.wtf.academy/docs/solidity-104/S08_ContractCheck/ 教程中讲解的非常清晰如何避免该漏洞,但示例代码中缺少安全合约的展示

Motivation(动机)

让通过该项目熟悉 solidity 的开发者更快更好的掌握solidity 的技术栈

Are you willing to submit a PR?(你愿意提交PR吗?)

  • Yes I am willing to submit a PR!(是的我愿意)
@XdpCs XdpCs changed the title [Feature][Module Name(模块名称)] Title(标题)S08_ContractCheck示例代码中增加 GoodContractCheck 的示例 [Feature]S08_ContractCheck示例代码中增加 GoodContractCheck 的示例 Nov 1, 2024
@XdpCs XdpCs self-assigned this Nov 4, 2024
@XdpCs XdpCs added the enhancement New feature or request label Nov 5, 2024
@XdpCs
Copy link
Collaborator

XdpCs commented Nov 5, 2024

我暂时没有找到很好的解决方案,我参考了openzeppelin。
如果后期有的话,欢迎提交pr。
ref: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3945/files

@XdpCs
Copy link
Collaborator

XdpCs commented Nov 5, 2024

在eip-3074中,会影响我们在教程中预防的例子。
ref: https://eips.ethereum.org/EIPS/eip-3074

@andOneBasketball
Copy link
Author

我暂时没有找到很好的解决方案,我参考了openzeppelin。 如果后期有的话,欢迎提交pr。 ref: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3945/files

好的,等我有空了来 fork 一下仓库提交个PR,一起看看我的想法是否能解决这个安全场景的问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants