feat: Remove border from accordion section and move chevron to the left #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
…into feature/DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
…into feature/DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
…into feature/DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
…into feature/DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
Co-authored-by: Vincent Smedinga <[email protected]>
Co-authored-by: Vincent Smedinga <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
dlnr
commented
Apr 16, 2024
…into feature/DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
VincentSmedinga
approved these changes
Apr 18, 2024
github-actions
bot
temporarily deployed
to
demo-DES-630-accordion-update
VincentSmedinga
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the border to panel has some consequences, the focus state thickens the border but only the button in the top is clickable. I've suggested another solution in Figma so I'll await the response before marking this as ready.
Update @VincentSmedinga: the border has been removed in a subsequent design iteration, and the chevron moved to the start of the line.