Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow overriding button labels in Alert, Dialog, Pagination, and Search Field #1220

Merged
merged 17 commits into from
May 16, 2024
Merged

feat: Allow overriding button labels in Alert, Dialog, Pagination, and Search Field #1220

merged 17 commits into from
May 16, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented May 7, 2024

No description provided.

@dlnr dlnr self-assigned this May 7, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 7, 2024 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 7, 2024 13:48 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Replaced hardcoded dutch label with props feat: Allow overriding button labels in Alert, Dialog, Pagination, and Search Field May 7, 2024
VincentSmedinga
VincentSmedinga reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some requests for the unit tests.

packages/react/src/Pagination/Pagination.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Dialog/Dialog.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Pagination/Pagination.test.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 7, 2024 14:25 Destroyed
alimpens
alimpens reviewed May 8, 2024
View reviewed changes
packages/react/src/Alert/Alert.tsx Outdated Show resolved Hide resolved
packages/react/src/Dialog/Dialog.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Pagination/Pagination.tsx Show resolved Hide resolved
packages/react/src/SearchField/SearchFieldButton.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 10, 2024 08:06 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 10, 2024 11:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 10, 2024 12:16 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 13, 2024 04:56 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 13, 2024 05:05 Destroyed
@VincentSmedinga VincentSmedinga requested a review from alimpens May 13, 2024 05:06
alimpens
alimpens reviewed May 14, 2024
View reviewed changes
packages/react/src/Alert/Alert.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Pagination/Pagination.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Pagination/Pagination.tsx Show resolved Hide resolved
packages/react/src/SearchField/SearchField.test.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 14, 2024 08:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 14, 2024 08:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 16, 2024 08:31 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-756-hardcoded-labels May 16, 2024 08:33 Destroyed
@VincentSmedinga VincentSmedinga merged commit c88e569 into develop May 16, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-756-hardcoded-labels branch May 16, 2024 08:39
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
@VincentSmedinga VincentSmedinga mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens left review comments

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

@RubenSibon RubenSibon Awaiting requested review from RubenSibon

Assignees

@dlnr dlnr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlnr @VincentSmedinga @alimpens