Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow additional background colours for Badge and remove dark blue option #1236

Merged
merged 2 commits into from
May 24, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented May 23, 2024

Processed all badge colors from the Figma file, and remove dark-blue which is only used for the hover color of primary blue. This is why we need a semantic color layer.

@github-actions github-actions bot temporarily deployed to demo-DES-628-badge-colors May 23, 2024 09:37 Destroyed
@dlnr dlnr changed the title Added all colours and remove dark blue feat: Badge additional colours May 23, 2024
@dlnr dlnr self-assigned this May 23, 2024
@RubenSibon
Copy link
Contributor

[...] remove dark-blue which is only used for the hover color of primary blue. This is why we need a semantic color layer.

Yeah, it's weird that light blue is allowed, but dark blue isn't.

You might as well change the colours for Avatar as that is heavily based on Badge.

RubenSibon
RubenSibon previously approved these changes May 23, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-628-badge-colors May 24, 2024 09:48 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Badge additional colours feat!: Allow additional background colours for Badge and remove dark blue option May 24, 2024
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ll be deciding on definitive colour names soon, so the options will probably change once more, but this is a good improvement until then. Let’s make Avatar consistent at that later moment.

@VincentSmedinga VincentSmedinga merged commit eec669a into develop May 24, 2024
5 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-628-badge-colors branch May 24, 2024 09:53
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants