Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Disallow directional style rules #1245

Merged

Conversation

alimpens
Copy link
Contributor

No description provided.

Copy link
Contributor

@RubenSibon RubenSibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although, that the CSS order has to change bothers me a bit. Sorting CSS alphabetically has never made sense to me. I don't understand why the industry hasn't adopted concentric CSS. If we had that then the re-ordering wouldn't have had to happen so much.

@@ -4,8 +4,8 @@
*/

.ams-logo {
block-size: var(--ams-logo-block-size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robbert mentioned that width and height may still be the better options for a logo, as we don’t want to rotate it in top-to-bottom writing modes. Another example is the video player.

On the other hand, “the left-to-right direction has become dominant in all three languages for horizontal writing due to the influence of Western languages and the increased use of computerized typesetting and word-processing software” (adapted from Wikipedia).

So we can probably get away with only supporting horizontal writing modes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm completely fine with making some exceptions for elements where that makes sense. It's probably something we should test on a complete page though. Maybe revisit it later, top-to-bottom writing modes aren't a huge priority at the moment I think?

@github-actions github-actions bot temporarily deployed to demo-DES-784-disallow-directional-style-rules June 3, 2024 21:17 Destroyed
@VincentSmedinga
Copy link
Contributor

That the CSS order has to change bothers me a bit. Sorting CSS alphabetically has never made sense to me. I don’t understand why the industry hasn’t adopted concentric CSS. If we had that then the re-ordering wouldn’t have had to happen so much.

I’ve always disliked CSS in alphabetical order as well :) In another project, I maintained my configuration of a Stylelint rule that forced a particular order. I wasn’t aware of concentric CSS, but it doesn’t seem very different from my approach.

However, even if we made a linter do all the work for us, a ‘better’ order would still ask other contributors to invest in it, and it also deviates from NLDS practice. Let’s keep this battle for another time.

@VincentSmedinga VincentSmedinga merged commit 8ab6f81 into develop Jun 3, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the fix/DES-784-disallow-directional-style-rules branch June 3, 2024 21:24
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants