Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Error Message #1247

Merged
merged 15 commits into from
Jun 5, 2024
Merged

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented May 31, 2024

I left out Label and ErrorMessage as child components of Field and FieldSet for now, for two reasons:

  • Label doesn't really makes sense as a child of FieldSet. It belongs to the input, not the FieldSet. ErrorMessage sometimes belongs to the FieldSet (RadioGroupWithError), sometimes it belongs to the input (WithError)
  • The displaynames seem to be set globally, so you can either have Label, Field.Label or FieldSet.Label as the displayname, not the first in 1 case and the second in another

I left out CheckboxGroupWithError for now, because I haven't yet found a way to get that working with NVDA. I'll write a new ticket to fix that.

@alimpens alimpens marked this pull request as draft May 31, 2024 15:42
@github-actions github-actions bot temporarily deployed to demo-DES-777-add-error-message May 31, 2024 15:42 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-777-add-error-message May 31, 2024 15:49 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-777-add-error-message June 3, 2024 14:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-777-add-error-message June 3, 2024 14:11 Destroyed
@alimpens alimpens marked this pull request as ready for review June 3, 2024 14:20
@github-actions github-actions bot temporarily deployed to demo-DES-777-add-error-message June 5, 2024 08:57 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-777-add-error-message June 5, 2024 09:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-777-add-error-message June 5, 2024 09:20 Destroyed
@VincentSmedinga VincentSmedinga merged commit 1dec2ea into develop Jun 5, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-777-add-error-message branch June 5, 2024 09:40
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants