-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Error Message #1247
Merged
Merged
feat: Add Error Message #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-777-add-error-message
May 31, 2024 15:42
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-777-add-error-message
May 31, 2024 15:49
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-777-add-error-message
June 3, 2024 14:05
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-777-add-error-message
June 3, 2024 14:11
Destroyed
RubenSibon
reviewed
Jun 4, 2024
Co-authored-by: Vincent Smedinga <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-777-add-error-message
June 5, 2024 08:57
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-777-add-error-message
June 5, 2024 09:05
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-777-add-error-message
June 5, 2024 09:20
Destroyed
VincentSmedinga
approved these changes
Jun 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left out
Label
andErrorMessage
as child components ofField
andFieldSet
for now, for two reasons:Label
doesn't really makes sense as a child ofFieldSet
. It belongs to the input, not the FieldSet.ErrorMessage
sometimes belongs to theFieldSet
(RadioGroupWithError
), sometimes it belongs to the input (WithError
)Label
,Field.Label
orFieldSet.Label
as the displayname, not the first in 1 case and the second in anotherI left out
CheckboxGroupWithError
for now, because I haven't yet found a way to get that working with NVDA. I'll write a new ticket to fix that.