Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow various types of text input #1259

Merged
merged 10 commits into from
Jun 21, 2024

Conversation

VincentSmedinga
Copy link
Contributor

This allows the types of password, email, url and phone for Text Inputs.

I’ve added initial documentation to each type and to the existing examples for disabled and invalid inputs and placeholder text.

@VincentSmedinga VincentSmedinga changed the title Allow various types of text input feat: Allow various types of text input Jun 13, 2024
Copy link
Contributor

@RubenSibon RubenSibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to add to Aram's comments. When those are addressed the branch is good for merging.

@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 14, 2024 15:14 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 15, 2024 09:38 Destroyed
@RubenSibon RubenSibon self-requested a review June 16, 2024 06:54
RubenSibon
RubenSibon previously approved these changes Jun 16, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 17, 2024 11:49 Destroyed
Copy link
Contributor

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a unit test for the type. Not that I personally miss this or think it should be necessary but we've been pretty strict about testing everything.

Co-authored-by: Aram <[email protected]>
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 19, 2024 12:06 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 19, 2024 13:17 Destroyed
@VincentSmedinga VincentSmedinga requested review from dlnr and alimpens June 19, 2024 13:20
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 19, 2024 13:22 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 19, 2024 13:27 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 21, 2024 12:12 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-739-text-input-types June 21, 2024 12:14 Destroyed
@VincentSmedinga VincentSmedinga merged commit dc1e5d5 into develop Jun 21, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-739-text-input-types branch June 21, 2024 12:17
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants