-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow various types of text input #1259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to add to Aram's comments. When those are addressed the branch is good for merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing a unit test for the type. Not that I personally miss this or think it should be necessary but we've been pretty strict about testing everything.
Co-authored-by: Aram <[email protected]>
Co-authored-by: Aram <[email protected]>
This allows the types of
password
,email
,url
andphone
for Text Inputs.I’ve added initial documentation to each type and to the existing examples for disabled and invalid inputs and placeholder text.