Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow specifiying a time in a date input #1262

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

VincentSmedinga
Copy link
Contributor

This allows the type of datetime-local for Date Inputs.

I copied the docs for disabled and invalid inputs from Text Input. We should probably extract this to some section on forms in general?

@github-actions github-actions bot temporarily deployed to demo-DES-739-date-input-types June 14, 2024 15:22 Destroyed
RubenSibon
RubenSibon previously approved these changes Jun 14, 2024
Copy link
Contributor

@RubenSibon RubenSibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to demo-DES-739-date-input-types June 15, 2024 09:41 Destroyed
@VincentSmedinga VincentSmedinga requested a review from alimpens June 15, 2024 09:42
@alimpens alimpens merged commit 9378432 into develop Jun 17, 2024
4 checks passed
@alimpens alimpens deleted the feature/DES-739-date-input-types branch June 17, 2024 07:13
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants