Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Merge ‘stack’ and ‘inside’ space categories and update components #1267

Merged
merged 27 commits into from
Jun 28, 2024

Conversation

VincentSmedinga
Copy link
Contributor

This merges the ‘Stack Space’ and ‘Inside Space’ categories to just ‘Space’.

The medium space widths are equal to the font sizes of Text Level 5: in Spacious Mode, it grows from 18px at 320px wide to 24px at 1600px wide. The smaller sizes are 50% and 25% of the medium width, the larger are 150% and 200%. So Spaces grows linearly, while Type grows exponentially. We’ll have to see if this doesn’t become weird, but it does make it simpler for now, especially in Figma, with only 2 lengths that aren’t integers.

I’ve made an inventory of all components using these types of space (paddings, gaps, and some margins) and applied them consistently. A next step can be to introduce some common spacing tokens, e.g. ams-text-input-appearance-padding-inline and ams-list-appearance-gap, which express some underlying design choices.

@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 19, 2024 20:00 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 21, 2024 12:37 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 21, 2024 12:41 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 23, 2024 10:36 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Consistently define whitespace for all components feat!: Merge ‘stack’ and ‘inside’ space and assign space consistently to all components Jun 24, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 25, 2024 10:52 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 26, 2024 08:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 27, 2024 13:25 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 27, 2024 14:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 28, 2024 09:44 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 28, 2024 09:56 Destroyed
storybook/src/docs/grid.docs.mdx Outdated Show resolved Hide resolved
storybook/src/docs/grid.docs.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 28, 2024 10:54 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat!: Merge ‘stack’ and ‘inside’ space and assign space consistently to all components feat!: Merge ‘stack’ and ‘inside’ space categories and update components Jun 28, 2024
RubenSibon
RubenSibon previously approved these changes Jun 28, 2024
# Conflicts:
#	storybook/src/components/Tabs/Tabs.stories.tsx
@github-actions github-actions bot temporarily deployed to demo-DES-727-spacious-space-tokens June 28, 2024 12:39 Destroyed
@VincentSmedinga VincentSmedinga requested a review from alimpens June 28, 2024 12:42
@alimpens alimpens merged commit a0de626 into develop Jun 28, 2024
7 checks passed
@alimpens alimpens deleted the feature/DES-727-spacious-space-tokens branch June 28, 2024 12:51
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants