-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Merge ‘stack’ and ‘inside’ space categories and update components #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 19, 2024 20:00
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 21, 2024 12:37
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 21, 2024 12:41
Destroyed
alimpens
reviewed
Jun 21, 2024
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 23, 2024 10:36
Destroyed
VincentSmedinga
changed the title
feat: Consistently define whitespace for all components
feat!: Merge ‘stack’ and ‘inside’ space and assign space consistently to all components
Jun 24, 2024
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 25, 2024 10:52
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 26, 2024 08:32
Destroyed
RubenSibon
reviewed
Jun 26, 2024
alimpens
reviewed
Jun 26, 2024
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 27, 2024 13:25
Destroyed
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 27, 2024 14:36
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 28, 2024 09:44
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 28, 2024 09:56
Destroyed
alimpens
reviewed
Jun 28, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 28, 2024 10:54
Destroyed
VincentSmedinga
changed the title
feat!: Merge ‘stack’ and ‘inside’ space and assign space consistently to all components
feat!: Merge ‘stack’ and ‘inside’ space categories and update components
Jun 28, 2024
RubenSibon
previously approved these changes
Jun 28, 2024
# Conflicts: # storybook/src/components/Tabs/Tabs.stories.tsx
github-actions
bot
temporarily deployed
to
demo-DES-727-spacious-space-tokens
June 28, 2024 12:39
Destroyed
alimpens
approved these changes
Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the ‘Stack Space’ and ‘Inside Space’ categories to just ‘Space’.
The medium space widths are equal to the font sizes of Text Level 5: in Spacious Mode, it grows from 18px at 320px wide to 24px at 1600px wide. The smaller sizes are 50% and 25% of the medium width, the larger are 150% and 200%. So Spaces grows linearly, while Type grows exponentially. We’ll have to see if this doesn’t become weird, but it does make it simpler for now, especially in Figma, with only 2 lengths that aren’t integers.
I’ve made an inventory of all components using these types of space (paddings, gaps, and some margins) and applied them consistently. A next step can be to introduce some common spacing tokens, e.g.
ams-text-input-appearance-padding-inline
andams-list-appearance-gap
, which express some underlying design choices.