feat!: Improve sizing behaviour of Dialog #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
reviewed
Jul 10, 2024
RubenSibon
reviewed
Jul 10, 2024
There was a problem hiding this comment.
I don't have much to add to Aram's comment, but I did notice that this example of how to open a dialog doesn't look right.
Fixed – the new |
There is no functional difference because `position: fixed` positions the dialog relative to the viewport. Bonus: they are direction-agnostic.
alimpens
approved these changes
Jul 12, 2024
Merged
dlnr
reviewed
Sep 10, 2024
| @@ -21,18 +27,14 @@ | |||
| .ams-dialog__form { | |||
| display: grid; | |||
| gap: var(--ams-dialog-form-gap); | |||
| grid-template-rows: auto 1fr auto; | |||
| max-block-size: var(--ams-dialog-form-max-block-size); | |||
There was a problem hiding this comment.
This broke the scrolling inside the Dialog (while keeping the action buttons in view).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the (maximum) block and inline sizes of a Dialog with our spacing system.
A Dialog now gets
The inner layout has been improved as well: making the
<dialog>a flex container automatically makes its child<form>size optimally. Setting heights for the grid rows of the form no longer seems necessary.It is a breaking change because the
dialog-form-max-block-sizetoken gets removed.