feat: Use flexbox and regular space in Column as we do in Row #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlnr
approved these changes
Jul 16, 2024
alimpens
approved these changes
Jul 17, 2024
github-actions
bot
temporarily deployed
to
demo-DES-882-2-use-flexbox-in-column
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My past self surprised me when I saw we were using CSS Grid and Grid Space in our Columns. Can’t find a rationale for it in the history of our commits and pull requests.
It may have been to separate Grids from each other, but it has padding props for that now. Or it had to do with the Calendar component on the new website’s homepage, but by now we agree that it shouldn’t use Grid Space.
It appears very logical to use flexbox in one-dimensional layout, as it does to use regular spacing lengths. This makes it match Row entirely.