Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial Password Input component #1449

Merged
merged 15 commits into from
Jul 30, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

A component to enter a password.

This is a bare MVP version. It does not include a button to show or hide the characters – there is no design for it yet; even more so, the need for it hasn’t been discussed yet. I would say the features we have in our other inputs are a good basis for this one. People can start using this component, get the correct styling, and feedback any requirements they may have. I also created a ticket for the feature to show the password.

Why

It was missing.

How

  • Scaffolded all files for a new component through plop
  • Used DateInput and TextInput as inspiration
  • Copied docs and tests from an earlier approach

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-DES-848-password-input July 26, 2024 14:24 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-848-password-input July 26, 2024 14:53 Destroyed
Copy link
Contributor Author

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, thorough as always! 💪🏻

@VincentSmedinga VincentSmedinga requested a review from alimpens July 26, 2024 14:54
@github-actions github-actions bot temporarily deployed to demo-DES-848-password-input July 27, 2024 17:24 Destroyed
@VincentSmedinga VincentSmedinga requested a review from alimpens July 27, 2024 17:24
@github-actions github-actions bot temporarily deployed to demo-DES-848-password-input July 30, 2024 08:01 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-848-password-input July 30, 2024 09:43 Destroyed
@alimpens alimpens merged commit 3cc863e into develop Jul 30, 2024
6 checks passed
@alimpens alimpens deleted the feature/DES-848-password-input branch July 30, 2024 09:49
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants