-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add initial Password Input component #1449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
reviewed
Jul 26, 2024
github-actions
bot
temporarily deployed
to
demo-DES-848-password-input
July 26, 2024 14:24
Destroyed
And change the value for autocapitalize from ‘none’ to ‘off’ for consistency with autocorrect.
github-actions
bot
temporarily deployed
to
demo-DES-848-password-input
July 26, 2024 14:53
Destroyed
VincentSmedinga
commented
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, thorough as always! 💪🏻
alimpens
reviewed
Jul 26, 2024
github-actions
bot
temporarily deployed
to
demo-DES-848-password-input
July 27, 2024 17:24
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-848-password-input
July 30, 2024 08:01
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-848-password-input
July 30, 2024 09:43
Destroyed
alimpens
approved these changes
Jul 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
A component to enter a password.
This is a bare MVP version. It does not include a button to show or hide the characters – there is no design for it yet; even more so, the need for it hasn’t been discussed yet. I would say the features we have in our other inputs are a good basis for this one. People can start using this component, get the correct styling, and feedback any requirements they may have. I also created a ticket for the feature to show the password.
Why
It was missing.
How
DateInput
andTextInput
as inspirationChecklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes