feat!: Use inline SVGs for Radio icon #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
alimpens
changed the title
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
dlnr
reviewed
Aug 13, 2024
dlnr
reviewed
Aug 13, 2024
|
This alignment of the text seems slightly off: 
Figma 
Storybook |
Co-authored-by: Vincent Smedinga <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
…msterdam/design-system into feat/DES-649-use-svg-for-radio
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
…into feat/DES-649-use-svg-for-radio
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
github-actions
bot
temporarily deployed
to
demo-DES-649-use-svg-for-radio
VincentSmedinga
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
It uses an inline SVG for the Radio icon and allows users to replace this icon. It also styles the default icon for correct display in forced colors mode.
Why
This makes it easier for external users to change the Icon. They can use their own SVGs and style them however they want to. This PR also fixes the display of Radios in forced colors mode.
How
By using an inline SVG with
ams-radio__circleandams-radio__checked-indicatorclasses, and styling those.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary: