-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove form from Dialog #1582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
reviewed
Sep 13, 2024
…into feature/DES-945-dialog-remove-form-2
github-actions
bot
temporarily deployed
to
demo-DES-945-dialog-remove-form-2
September 13, 2024 13:22
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-945-dialog-remove-form-2
September 13, 2024 13:33
Destroyed
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-945-dialog-remove-form-2
September 13, 2024 14:51
Destroyed
….com/Amsterdam/design-system into feature/DES-945-dialog-remove-form-2
github-actions
bot
temporarily deployed
to
demo-DES-945-dialog-remove-form-2
September 13, 2024 15:05
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-945-dialog-remove-form-2
September 16, 2024 08:43
Destroyed
alimpens
reviewed
Sep 17, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-945-dialog-remove-form-2
September 17, 2024 08:36
Destroyed
alimpens
approved these changes
Sep 17, 2024
VincentSmedinga
changed the title
feat!: Remove Form in Dialog
feat!: Remove form from Dialog
Sep 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
The form inside the dialog should be optional because there is a need to built larger forms in the popup. Besides that the vertical scroll (for long content) was broken by moving CSS to the dialog instead of the form wrapping the content. I've taking the liberty to recover some of that work but then rename the element: "form > content" and "actions > footer". The latter to illustrate that you are adding children to a (sticky) footer component.
What
Actions become footer and some changes in tokens.
Why
To allow developers to work with content other then
<form method="dialog">
and to document how to use it if you want.How
form
attribute on the submit button when it's in the footer.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes