Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Image Slider component #1595

Merged
merged 73 commits into from
Oct 3, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Sep 23, 2024

Describe the pull request

The same image slider but with an object to define the images, this improves the rendering of thumbnails. Also disabled the scrolling of thumbnails, instead it will turn into a wrapped grid when you add more then 5 images.

What

  • Object driven component
  • Keyboard navigation for thumbnails
  • multiple rows grid for thumbnails
  • Improved aria roles

Why

Having a slider with children complicated the markup and dupliating the thumbnails as buttons was an ugly solution.

How

The slides object is fairly simple and the source of the image was now easy to use in a background-image for the button
The aspect-ratio class usage might change after Ruben's changes to the component.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

dlnr and others added 30 commits July 16, 2024 20:27
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 2, 2024 09:41 Destroyed
@dlnr
Copy link
Contributor Author

dlnr commented Oct 2, 2024

Having some trouble moving slides to a child component, also not sure if moving all everything to a shared context is more performant. We discussed this and decided to optimise this later.

@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 2, 2024 09:49 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 3, 2024 12:13 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 3, 2024 12:58 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 3, 2024 14:03 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 3, 2024 14:11 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 3, 2024 14:19 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 3, 2024 14:27 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-869-image-slider-object October 3, 2024 14:29 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

packages/react/src/ImageSlider/ImageSlider.tsx Outdated Show resolved Hide resolved
packages/react/src/ImageSlider/ImageSlider.tsx Outdated Show resolved Hide resolved
packages/react/src/ImageSlider/ImageSlider.tsx Outdated Show resolved Hide resolved
@VincentSmedinga VincentSmedinga merged commit 58e7766 into develop Oct 3, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-869-image-slider-object branch October 3, 2024 14:37
@VincentSmedinga VincentSmedinga changed the title feat: Image slider feat: Add Image Slider component Oct 3, 2024
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants