-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Image Slider component #1595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/DES-869-image-slider
…into feature/DES-869-image-slider
…into feature/DES-869-image-slider
…into feature/DES-869-image-slider
…terdam/design-system into feature/DES-869-image-slider
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 2, 2024 09:41
Destroyed
Having some trouble moving slides to a child component, also not sure if moving all everything to a shared context is more performant. We discussed this and decided to optimise this later. |
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 2, 2024 09:49
Destroyed
RubenSibon
reviewed
Oct 2, 2024
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 3, 2024 12:13
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 3, 2024 12:58
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 3, 2024 14:03
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 3, 2024 14:11
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 3, 2024 14:19
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 3, 2024 14:27
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-869-image-slider-object
October 3, 2024 14:29
Destroyed
VincentSmedinga
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
The same image slider but with an object to define the images, this improves the rendering of thumbnails. Also disabled the scrolling of thumbnails, instead it will turn into a wrapped grid when you add more then 5 images.
What
Why
Having a slider with children complicated the markup and dupliating the thumbnails as buttons was an ugly solution.
How
The slides object is fairly simple and the source of the image was now easy to use in a background-image for the button
The aspect-ratio class usage might change after Ruben's changes to the component.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes