-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Use new Button features for SearchField #1695
feat!: Use new Button features for SearchField #1695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a logical change, which can also be done in Figma. But i don't get the extra layer of SearchField.Button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but do address @dlnr's comment about using the Button
component directly.
747ef9e
Co-authored-by: Aram <[email protected]>
Describe the pull request
Comments in Search Field suggested reusing Icon Button. Now that we’re replacing that with an icon-only button, I wondered if that could be a drop-in replacement. And… it is! I found no visual or other regressions.
What
Use Icon Button for Search Field Button.
Why
Reuse existing components.
How
SearchField.Button
as a better API than letting consumers use IconButton explicitly in SearchField.icon
,iconPosition
andvariant
props on Search Field Button, although having a visible ‘Zoeken’ label doesn’t seem bad either.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
SearchField.Input
toSearchInput
and make this thing a pattern?