-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Post results as a comment in the PR #3
Comments
Thanks @lexicalunit, |
Sadly I don't know of any examples. I'm just going off the documentation which says that it does make a comment with such details. |
So those links work just fine, but those are only active when the checks are running or if one of the checks has failed. If the checks ran and ran without errors, then all those checks get rolled up and aren't immediately visible anymore. Also sometimes if you aren't using parallel tests you may have your coveralls step not broken out like that, so you'd only see one single check, and you'd have no indication that the test included any sort of coverage tests. That's why most tools, including https://github.com/marketplace/actions/coveralls-github-action according to its own documentation, and indeed also codecov do things like you see in this PR: theastropath/turbot#68 Where the final step will be to create and/or update a comment in the PR (and only if the build is based on a PR, it wouldn't do it for a push event) with details about the run. All I know is that https://github.com/marketplace/actions/coveralls-github-action claims to support this feature... I'm sure if it does there must be some project out there somewhere with an example of what their comment might look like. |
Ah, I found an example in the wild of a comment like this: repetere/jsonm#3 (comment) |
Very nice, I thought only codecov was capable of it. Have an example really helps. Well I'll look into it then |
With this config, I get the standard GH "CI box" (here, heading "Some checks were not successful"). The "Details" link from "coveralls_finish (pull_request)" just points to the Actions tab for the check, where there is no link to Coveralls.io, nor anything else useful, really (I verified that the results were actually posted correctly to Coveralls, although the "Commit Message" there (on Coveralls.io) is a garbled mess of HTML... 🤔). Am I missing some necessary magic to get any link to Coveralls.io? EIT: Self answer. It really does require |
I tried for a couple hours to get https://github.com/marketplace/actions/coveralls-github-action together with https://pypi.org/project/coveralls/ working correctly and it just never did.
But your action worked perfectly my first attempt! Thank you! 🎉
One thing that would be nice that I think
coveralls-github-action
does is that it posts a detailed comment to the PR with results linking to the coveralls report as well. Without this it's not obvious where to find the report, or that it even exists, unless you go looking for it on coveralls.io yourself.The text was updated successfully, but these errors were encountered: