Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering for Event Log tasks #54

Open
fubuloubu opened this issue Feb 16, 2024 · 1 comment · May be fixed by #55
Open

Allow filtering for Event Log tasks #54

fubuloubu opened this issue Feb 16, 2024 · 1 comment · May be fixed by #55
Labels
bug Something isn't working enhancement New feature or request

Comments

@fubuloubu
Copy link
Member

fubuloubu commented Feb 16, 2024

Overview

Allow specifying indexed parameters to reduce the amount of events grabbed by an event log task

Specification

@app.on_(USDC.Transfer, to=app.signer)
def receive_task(log):
    ... # Do something on receiving USDC to the app signer account

Note that it should be pretty nice to be able to use un-converted objects to use filter with, but sometimes the name of indexed event arguments are not valid Python identifiers such as from, so an alternative method should be specified to work around that and potential name conflicts with other kwargs to this method e.g. start_block (perhaps a kwarg filter_args={...} that gets merged with the remaining **kwargs on app.on_)

Dependencies

May require updates to Core first

#55

@fubuloubu fubuloubu added the enhancement New feature or request label Feb 16, 2024
Copy link

linear bot commented Feb 16, 2024

@mikeshultz mikeshultz linked a pull request Feb 22, 2024 that will close this issue
4 tasks
@vany365 vany365 added the bug Something isn't working label Mar 15, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants