Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit checkers and their tests #3

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Add commit checkers and their tests #3

merged 3 commits into from
Sep 7, 2021

Conversation

weisunOW
Copy link
Collaborator

@weisunOW weisunOW commented Sep 7, 2021

No description provided.

@weisunOW weisunOW self-assigned this Sep 7, 2021
@AppDifferentiaDangerSwiftBot
Copy link

AppDifferentiaDangerSwiftBot commented Sep 7, 2021 •
edited
Loading

File Coverage
Sources/DangerSwiftCommitLint/CommitChecker/BodyEmptyLineCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/CommitChecker.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/CommitMessage.swift 91.666664% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectCapCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectLengthCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectPeriodCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectWordCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/Extensions/RegexHelper.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/BodyEmptyLineCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/CommitMessageTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/Fixtures/CommitJSONParser.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectCapCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectLengthCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectPeriodCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectWorkCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/Extensions/RegexHelperTests.swift 100.0% ✅

Generated by 🚫 Danger Swift against cf4426e

Wei Sun added 2 commits September 7, 2021 16:42
[Implementation] Add commit checkers and their tests
691f8a6
[CI] Assign danger_id to two danger steps
4022e47 
This update avoids two danger steps overwriting each other's comment
weisunOW
weisunOW commented Sep 7, 2021
View reviewed changes
Copy link
Collaborator Author

@weisunOW weisunOW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also assigns different danger_id to each danger step on the action.

@AppDifferentiaDangerSwiftBot
Copy link

AppDifferentiaDangerSwiftBot commented Sep 7, 2021 •
edited
Loading

File Coverage
Sources/DangerSwiftCommitLint/CommitChecker/BodyEmptyLineCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/CommitChecker.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/CommitMessage.swift 91.666664% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectCapCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectLengthCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectPeriodCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/CommitChecker/SubjectWordCheck.swift 100.0% ✅
Sources/DangerSwiftCommitLint/Extensions/RegexHelper.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/BodyEmptyLineCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/CommitMessageTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/Fixtures/CommitJSONParser.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectCapCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectLengthCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectPeriodCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/CommitChecker/SubjectWorkCheckTests.swift 100.0% ✅
Tests/DangerSwiftCommitLintTests/Extensions/RegexHelperTests.swift 100.0% ✅

Generated by 🚫 Danger Swift against 0f1b271

AppDifferentia
AppDifferentia approved these changes Sep 7, 2021
View reviewed changes
Copy link
Owner

@AppDifferentia AppDifferentia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@weisunOW weisunOW merged commit c944159 into master Sep 7, 2021
@weisunOW weisunOW deleted the add-commit-checkers branch September 7, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AppDifferentia AppDifferentia AppDifferentia approved these changes

Assignees

@weisunOW weisunOW

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weisunOW @AppDifferentiaDangerSwiftBot @AppDifferentia