Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[won't fix] Node server should also allow listen on Unix socket #13

Closed
mave99a opened this issue Jan 15, 2019 · 1 comment
Closed

[won't fix] Node server should also allow listen on Unix socket #13

mave99a opened this issue Jan 15, 2019 · 1 comment
Assignees
@wangshijun
Labels
area/client priority/not-urgent

Comments

@mave99a
Copy link
Contributor

mave99a commented Jan 15, 2019

Unix socket is more efficient

reference:

https://stackoverflow.com/questions/7045614/can-node-js-listen-on-unix-socket
@wangshijun
Copy link
Contributor

@mave99a My initial plan is connecting using unix socket between forge-core and forge-app, but due to limitations of grpc-node (checkout this issue: grpc/grpc-node#258), currently, only tcp is supported

@wangshijun wangshijun self-assigned this Jan 15, 2019
@wangshijun wangshijun changed the title Node server should also allow listen on Unix socket [Will node fix by now] Node server should also allow listen on Unix socket Jan 23, 2019
@wangshijun wangshijun changed the title [Will node fix by now] Node server should also allow listen on Unix socket [won't fix] Node server should also allow listen on Unix socket Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangshijun wangshijun

Labels
area/client priority/not-urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mave99a @wangshijun