Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #14 - Added new puzzles #46

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Issue #14 - Added new puzzles #46

merged 2 commits into from
Oct 30, 2019

Conversation

zufishanali
Copy link
Contributor

As per the request in issue #14, I have added 3 new rhymes to file puzzles.js.

Arcaster42
Arcaster42 requested changes Oct 30, 2019
View reviewed changes
Copy link
Owner

@Arcaster42 Arcaster42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time and effort! The puzzles are great. Please see the review comments for some minor changes, and then I'll be ready to merge!

src/js/puzzles.js Outdated Show resolved Hide resolved
src/js/puzzles.js Outdated Show resolved Hide resolved
Arcaster42
Arcaster42 approved these changes Oct 30, 2019
View reviewed changes
Copy link
Owner

@Arcaster42 Arcaster42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Arcaster42 Arcaster42 merged commit c919345 into Arcaster42:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcaster42 Arcaster42 Arcaster42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zufishanali @Arcaster42