Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for scripting in flash using littlefs #28724

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

andyp1per
Copy link
Collaborator

@andyp1per andyp1per commented Nov 24, 2024

This completely replaces the flash based support, including logging with a littlefs backend. This results in much more reliable FS access as well as support for things like scripting.

With thanks to @ntamas for the original code

@andyp1per andyp1per added the WIP label Nov 24, 2024
@tpwrules
Copy link
Contributor

Oh excellent!! Have you tried with both NOR and NAND?

@andyp1per
Copy link
Collaborator Author

Oh excellent!! Have you tried with both NOR and NAND?

No, still a lot of work to do as there is lots of duplication currently. The code is from @ntamas but needs a bunch of rework to get into master. I have a plan, but the main thing is that it now works for me locally and I know how to proceed from here.

@ntamas
Copy link
Contributor

ntamas commented Nov 25, 2024

Let me know if I can help with reworking this PR for inclusion. This is something that we at @skybrush-io would also be interested in.

@jpkh
Copy link
Contributor

jpkh commented Nov 26, 2024

Oh yes, there are a lot small H743 based FPVDrone FCs that only have dataflash. This will be important update to all those (and others). Thanks Andy.

@robustini
Copy link
Contributor

Thanks Andy, this will be most useful!

@andyp1per
Copy link
Collaborator Author

@ntamas actually it's not so bad - I think what you have done is correct. I really want the block logger to die, but I don't think that's going to be possible on boards with very small flash chips

@tridge
Copy link
Contributor

tridge commented Nov 29, 2024

it will be very interesting to see how this goes! and some stats on storage overhead (and flash cost) would be useful

@tridge
Copy link
Contributor

tridge commented Nov 29, 2024

@andyp1per assuming this works out and testing is good, we should fork littlefs so we point to our own github org, we've tended to regret it when we don't do that

@andyp1per andyp1per marked this pull request as ready for review November 29, 2024 21:49
@andyp1per andyp1per removed the WIP label Nov 29, 2024
@andyp1per
Copy link
Collaborator Author

Working quite nicely for me now. Not yet flown it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants