Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Save to disk" feature #30

Closed
Arsenic-ATG opened this issue Aug 29, 2021 · 7 comments
Closed

Add "Save to disk" feature #30

Arsenic-ATG opened this issue Aug 29, 2021 · 7 comments
Assignees
@Arsenic-ATG
Labels
enhancement New feature or request

Comments

@Arsenic-ATG
Copy link
Owner

Currently the editor is more like a scratch pad, which only saves the changes temporarily and they are lost after quitting.

A basic editor needs to have ability to save the edited file to the disk.
@Arsenic-ATG Arsenic-ATG self-assigned this Aug 29, 2021
@Arsenic-ATG Arsenic-ATG added the enhancement New feature or request label Aug 29, 2021
@Arsenic-ATG
Copy link
Owner Author

Maybe it should be triggered on a key combination ( like ctrl + s )

@Arsenic-ATG
Copy link
Owner Author

Challenge: how to prompt the user about "where to save file ?"

@Arsenic-ATG
Copy link
Owner Author

Maybe an indication to the user if the file is saved or not ( in the status bar ) should also help

@Arsenic-ATG
Copy link
Owner Author

the feature is partially implemented after 1fbec7d

@Arsenic-ATG Arsenic-ATG mentioned this issue Aug 29, 2021
Closed
@Arsenic-ATG Arsenic-ATG added the Blocked This issue should not be resolved until another issue is resolved label Aug 29, 2021
@Arsenic-ATG
Copy link
Owner Author

Arsenic-ATG commented Aug 29, 2021 •
edited
Loading

Blocked by issue #31

Update: blocking issue fixed.

@Arsenic-ATG Arsenic-ATG removed the Blocked This issue should not be resolved until another issue is resolved label Aug 31, 2021
@Arsenic-ATG
Copy link
Owner Author

after 1fbec7d , the save to disk feature should work as intended if the editor is editing an already open file.

I still doesn't got a way to handle the case where no file is open.

@Arsenic-ATG
Copy link
Owner Author

Arsenic-ATG commented Aug 31, 2021 •
edited
Loading

tracking "saving when no file is open" with issue #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arsenic-ATG Arsenic-ATG

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Arsenic-ATG