Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libssl1 for tarpaulin #1412

Closed
wants to merge 3 commits into from
Closed

libssl1 for tarpaulin #1412

wants to merge 3 commits into from

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Attempt to fix the botched CI job due to the missing libssl1.

@Dinonard Dinonard added the ci This PR/Issue is related to the topic "CI" label Jan 16, 2025
@grbIzl
Copy link

grbIzl commented Jan 16, 2025

I think @ipapandinas is trying to fix this issue with general bump of tarpaulin here #1408

Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/assets-erc20/src 78% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/xcm/src 71% 0%
chain-extensions/types/assets/src 0% 0%
pallets/vesting-mbm/src 89% 0%
precompiles/sr25519/src 64% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
precompiles/dapp-staking/src/test 0% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
primitives/src 55% 0%
primitives/src/xcm 65% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/unified-accounts/src 86% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
pallets/ethereum-checked/src 74% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking/src 83% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/dapp-staking/src 90% 0%
pallets/collective-proxy/src 86% 0%
pallets/inflation/src 89% 0%
pallets/price-aggregator/src 82% 0%
pallets/static-price-provider/src 85% 0%
Summary 79% (3736 / 4753) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard
Copy link
Member Author

Dinonard commented Jan 16, 2025

I think @ipapandinas is trying to fix this issue with general bump of tarpaulin here #1408

I've seen the PR, but it's still failing.

Anyways, we shouldn't spend too much time on it since it's been deprecated.
#1411

EDIT: Seems I was wrong, the gh action's been deprecated but tool is still valid.

@ipapandinas
Copy link
Contributor

ipapandinas commented Jan 16, 2025

@grbIzl @Dinonard - Yes only the GH action has been deprecated.
I tried to install the latest version of tarpaulin directly. However, I can't exclude files for the generated report, the --exclude-files doesn't work as expected or I missed something, no matter if I pass the paths inline or individually.

I didn't want to spend too much time investigating, the quick fix proposed here (installing libssl) seems good enough to avoid blocking future PRs.

Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM {as temp fix}

.github/workflows/coverage.yaml Show resolved Hide resolved
@Dinonard
Copy link
Member Author

Closing since #1408 was fixed.

@Dinonard Dinonard closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR/Issue is related to the topic "CI"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants