Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Achievements get announced when they get synchronized #10

Closed
BrainStone opened this issue Apr 27, 2017 · 1 comment
Closed

Achievements get announced when they get synchronized #10

BrainStone opened this issue Apr 27, 2017 · 1 comment
Assignees
@BrainStone
Labels
bug
Milestone
1.0.0

Comments

@BrainStone
Copy link
Member

Issue Description:

When achievments are synchronized they get announced as if the player just got them.

What happens:

When the server synchronizes the achievements, new ones get announced.

What you expected to happen:

No announcements

Steps to reproduce:

  1. Get some achievements
  2. Leave server
  3. Delete stats file
  4. Join server
  5. Get greeted by achievement got message(s)

Affected Versions (Do not use "latest"):

  • Minecraft: 1.11.2
  • InvSync: 0.5.19-beta
  • Sponge: 1.11.2-6.0.0-BETA-253
@BrainStone BrainStone added the bug label Apr 27, 2017
@BrainStone BrainStone self-assigned this Apr 27, 2017
@BrainStone
Copy link
Member Author

BrainStone commented Apr 27, 2017 •
edited
Loading

Comment from Meronat on IRC

I believe it's thrown but I'm not sure. The GrantAchievementEvent extends the MessageChannelEvent so you can cancel the messages
Event#setMessageCancelled(true)

@BrainStone BrainStone modified the milestone: 1.0.0 May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrainStone BrainStone

Labels
bug
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@BrainStone