Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grunt support #585

Closed
SiR-DanieL opened this issue Aug 18, 2014 · 3 comments
Closed

Add Grunt support #585

SiR-DanieL opened this issue Aug 18, 2014 · 3 comments

Comments

@SiR-DanieL
Copy link
Member

What do you think about adding Grunt support?
I usually use Grunt, and would be awesome to have a ready-to-use configuration.

I'm actually working on it, but i only added watch and uglify tasks.
If it's ok, i'll add also sass, cssmin and jshint

@SiR-DanieL SiR-DanieL changed the title Adding Grunt support Add Grunt support Aug 18, 2014
@karmatosed
Copy link
Contributor

For now, my vote is leave it out. If Grunt was to be added it should be a checkbox/ option like Sass rather than rolled into _s core.

Worth noting, is if you did want this the best way just like Sass is to create a fork. Even if it doesn't get used, you can use it and so can others. There is no need for everything to be in _s. People want different things and taking your own route with a fork isn't a bad way to do things.

@SiR-DanieL
Copy link
Member Author

Ok, however i think it would be useful for everybody, also you will not be required to use it.
For example, for minified JS files, we should only add an if statement and check if a file-name.min.js file exists. If not, then use the default file-name.js instead.

If the user uses grunt, he will run it and create the minified files, else he can do it manually, or do not use minified files at all. Same is for css/scss.

While i think jshint would be really helpful. There are coding standards in WP and this would help a little bit to spread them and have a clean and maintenable code.

@karmatosed
Copy link
Contributor

Everyone is a rather wide statement. For example, I do not use Grunt myself. Not everyone does. Same with jshint. I don't use that either and personally, I'd not want _s to have both of those in without it being opt in.

I really do think the best route for you with this would be to get a fork and take from there like we did with Sass. I look forward to seeing what you create, for now I hope you don't mind me closing this as it's not something we're going to add right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants