Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS Linting #936

Closed
peiche opened this issue Mar 9, 2016 · 6 comments
Closed

SCSS Linting #936

peiche opened this issue Mar 9, 2016 · 6 comments

Comments

@peiche
Copy link

peiche commented Mar 9, 2016

Since Underscores' stylesheet is generated by Sass, would it be beneficial to have a scss-lint configuration file?

@jaakkolehtonen
Copy link

Ive been using stylelint and it's been create since it has config for wp's css coding standards. Cool thing is it lint's both css and scss!

@anagio
Copy link

anagio commented Mar 27, 2016

Leave it out, because people who have dev environments already setup with grunt, gulp etc will likely have linters already setup from past projects. If they want to use stylelint they can add it. For anyone not linting it's an extra file in the code base that's taking up space. And if it did get added, what's next jslint? This is a minimal bare bones starter theme it should stay that way without any extras.

@jrfnl
Copy link
Contributor

jrfnl commented Mar 27, 2016

And if it did get added, what's next jslint?

That's actually already included in the Travis run - see #888

@karmatosed
Copy link
Contributor

I would vote no as it's up to each person.

@peiche
Copy link
Author

peiche commented Mar 28, 2016

Do the Underscores team not lint their SCSS/CSS as they add or edit it?

@karmatosed
Copy link
Contributor

How we each choose to do things is our own. The Underscores team is not just Automattic, it's everyone that contributes to. If you are asking at Automattic what we do, we have no one method and allow the themer to chose their path. As I am saying should happen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@karmatosed @peiche @jrfnl @anagio @sixhours @jaakkolehtonen and others