-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payment Block 3 rows #196
Comments
This one needs work on the text and images because right now it doesn't feel real. Once the images are swapped, the text needs to be aligned with the subject. |
I see a horizontal scrollbar when I preview it. I think you don't need to get rid of the padding from the most-outer Group block in the pattern. The rhythm of vertical spacing seems a bit off. I don't think all the vertical gaps don't have to be the same, (and it's probably impossible to make them the same with the current tool) but it should make sense with the flow of the contents. (1) seems to be too little. (2) seems to be too generous. I wonder if it looks good if the width of the button is a little narrower. I think the size of paragraphs (3) is a bit too large for the layout. |
I just saw some of those images in Unsplash, and I've noticed those are sponsored images from Microsoft. Let's stay away from any sponsored images in Unsplash. |
Sorry, this fell in the cracks. I assume it's been a tough task to find three images for a product that we feel ok to use in a pattern. They aren't very inspiring at the moment. The images on the left and the right are flat and are taken with very similar perspectives. I don't dislike the middle. Could you do another go to find something that work better with this concept? What do you think about the wide button? It's too wide for a not obvious reason to me. I remember this was initially designed by someone else, but feel free to improve as you go. |
Never thought I'd play with the design itself and thanks for bringing that up! 😄 I'll def give the button tweak a go. And yes, the images were though to come by as a group but you're right I'll give it another try. |
Preview →
3 rows layout, wrapped within a full width zero gap group block.
@ianstewart @olaolusoga @alaczek @iamtakashi
The text was updated successfully, but these errors were encountered: