Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Text and Media #270

Open
onuro opened this issue Aug 22, 2022 · 6 comments
Open

Subscription Text and Media #270

onuro opened this issue Aug 22, 2022 · 6 comments
Milestone

Comments

@onuro
Copy link

onuro commented Aug 22, 2022

Screenshot:
image

<!-- wp:media-text {"align":"full","mediaPosition":"right","mediaId":5987,"mediaLink":"https://dotcompatterns.wordpress.com/?attachment_id=5987","mediaType":"image","style":{"color":{"background":"#fdfcfa"}}} -->
<div class="wp-block-media-text alignfull has-media-on-the-right is-stacked-on-mobile has-background" style="background-color:#fdfcfa"><div class="wp-block-media-text__content"><!-- wp:group {"style":{"spacing":{"blockGap":"30px","padding":{"bottom":"50px"}}},"layout":{"inherit":true}} -->
<div class="wp-block-group" style="padding-bottom:50px"><!-- wp:heading {"style":{"typography":{"fontStyle":"normal","fontWeight":"700","fontSize":"4rem","lineHeight":1.2}}} -->
<h2 style="font-size:4rem;font-style:normal;font-weight:700;line-height:1.2">Best recipes. Delivered to your mail</h2>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Subscribe to our newsletter for cool tips, campaigns and new things.</p>
<!-- /wp:paragraph -->

<!-- wp:jetpack/subscriptions {"buttonWidth":"","submitButtonText":"\u003cstrong\u003e Subscribe \u003c/strong\u003e","customButtonBackgroundColor":"#8f72b4","borderRadius":4,"borderWeight":0,"customBorderColor":"#8f72b4","padding":15,"spacing":10,"className":"is-style-split"} -->
<div class="wp-block-jetpack-subscriptions wp-block-jetpack-subscriptions__supports-newline is-style-split">[jetpack_subscription_form show_subscribers_total="false" button_on_newline="false" submit_button_text="&lt;strong&gt; Subscribe &lt;/strong&gt;" custom_background_button_color="#8f72b4" custom_font_size="16px" custom_border_radius="4" custom_border_weight="1" custom_border_color="#8f72b4" custom_padding="15" custom_spacing="10" submit_button_classes="" email_field_classes="" show_only_email_and_button="true" success_message="Success! An email was just sent to confirm your subscription. Please find the email now and click &#039;Confirm Follow&#039; to start subscribing."]</div>
<!-- /wp:jetpack/subscriptions --></div>
<!-- /wp:group --></div><figure class="wp-block-media-text__media"><img src="https://dotcompatterns.files.wordpress.com/2022/08/rightside-image.png?w=563" alt="" class="wp-image-5987 size-full"/></figure></div>
<!-- /wp:media-text -->

Preview:
https://dotcompatterns.wordpress.com/?p=5985&preview=true

@onuro onuro added this to the Subscription milestone Aug 22, 2022
@alaczek
Copy link
Contributor

alaczek commented Aug 25, 2022

I think this one needs some more work:

  • I'm not sure about the use of the word "mail". I think "email" or "inbox" would make more sense.
  • It's strange there's no period after "Delivered to your mail" - I think both sentences should use a period, or the text should be merged into one sentence. "Best recipes delivered to your email."
  • It would be great if the paragraph below was more connected to the heading and also mentioned culinary things.
  • The mobile version needs tweaking - the image comes up first on mobile and forces you to scroll to get to the signup form.

@onuro
Copy link
Author

onuro commented Aug 25, 2022

Thanks for the inputs Ola. Ive' updated the copy. For mobile, trouble is the media/text block always puts the image on top when stacked. And if I try columns, the image is not super compatible to place inside a cover. What I did was decrease the height of the image and re-upload.

image

Let me know what you think. If we think this image is not working, I'll try find something else that would work well with a cover.

@alaczek
Copy link
Contributor

alaczek commented Sep 26, 2022

The cut-out is clever, but the image is not a great fit with the heading below. So yeah, I think it would be best to look at some other image options.

@onuro
Copy link
Author

onuro commented Sep 27, 2022

Thanks! What do you think about this one? @iamtakashi @alaczek

image

Personally I think I might want to lighten up the bg a bit more if I can without destroying the image.

@iamtakashi
Copy link
Contributor

The widows in both texts jumped out to me. ("mail" and "things") We can't guarantee it to not happen all the time, but if it can be avoided most of the time by changing the copy slightly, let's do that.

Also, don't we need a full stop at the end of the heading?

@alaczek
Copy link
Contributor

alaczek commented Sep 30, 2022

Yep, agree with Takashi about the widows. Maybe shorten the heading to "Best recipes, delivered to you." or "Best recipes. Delivered to you."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants