Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline inline style outputs code on the front end #140

Open
kathrynwp opened this issue Jan 31, 2023 · 11 comments
Open

Underline inline style outputs code on the front end #140

kathrynwp opened this issue Jan 31, 2023 · 11 comments
Labels
bbpress bug Something isn't working

Comments

@kathrynwp
Copy link
Member

kathrynwp commented Jan 31, 2023

While the Underline option is provided as an inline style, it isn't displayed correctly.

To replicate

  • Select some text in a forum post
  • Click the upside-down caret icon and apply the Underline option
  • Submit the post

Result

Before submission the underlined text looks OK in the editor:

A____Would_Review_Again_-__Test_Plugin_3__Review___WordPress_org

Once submitted, inline HTML is visible on the front end:

A____Would_Review_Again_-__Test_Plugin_3__Review___WordPress_org

Expected

Underlining should be displayed on the front end instead of HTML and inline CSS.

Note

The inline options appear to be different in the live WP.org Support forums than in the test forum, which may be why this was not caught earlier. If it would be possible to get the test forum in sync with the live forum, it would be helpful.

Test Forum Inline Options

Test___WordPress_org_Testing_Rosetta

Live Forum Inline Options

Includes Justify & Underline options:

Localhost_Installs___WordPress_org

Report

Reported in Slack here

@kathrynwp kathrynwp added bug Something isn't working bbpress labels Jan 31, 2023
@johngodley
Copy link
Member

Where are you seeing the underline option? It is not part of the plugin.

@kathrynwp
Copy link
Member Author

@johngodley Weird! It's in the live forums, for example when creating a post:

https://wordpress.org/support/forum/how-to-and-troubleshooting/?view=all#new-topic-0

@johngodley
Copy link
Member

It's not part of Gutenberg itself, or this plugin, so must be something added on that forum but not the test ones. If it is supposed to be there then it will need to be added to the KSES filters.

@kathrynwp
Copy link
Member Author

OK! What's the best way to address this, do you think I should make a Meta ticket, or something else?

@kathrynwp
Copy link
Member Author

I don't think we need underlining or justification in the forums, personally.

@porg
Copy link

porg commented Jan 31, 2023

Underlining may be important when users want to mimick a link without creating a real one, when paraphrasing an error message, bug or proposal. A situation which is realistic on a support forum for a CMS.

@porg
Copy link

porg commented Jan 31, 2023

Or when quoting text which has underlines, which is possible in Gutenberg.

Why limit expression?

@johngodley
Copy link
Member

@kathrynwp I don't know what the process is, maybe @dd32 can advise. If it's not intentional then it's probably a plugin or configuration thats running on the main forums but not the test one.

@johngodley
Copy link
Member

Actually, trying the wp.com editor it appears there (along with some others) so I'm guessing it's Jetpack.

@porg
Copy link

porg commented Jan 31, 2023

@johngodley
Copy link
Member

Could that also be the root cause for #135

No. As far as I know that is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bbpress bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants