Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images and videos are not embedded in comments. #10682

Open
julsyd opened this issue Nov 20, 2018 · 11 comments
Open

Images and videos are not embedded in comments. #10682

julsyd opened this issue Nov 20, 2018 · 11 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Shortcodes / Embeds [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@julsyd
Copy link

julsyd commented Nov 20, 2018

On WP.com simple sites, users can share a link to an image or YouTube video in a comment and the embedded image/video will appear in the published comment. This functionality is lost when a site goes AT.

Originally reported here: 522-gh-atomic

@jeherve jeherve added the [Closed] Won't Fix wontfix. This issue will not be addressed. label Nov 20, 2018
@jeherve
Copy link
Member

jeherve commented Nov 20, 2018

I would recommend following the instructions here to allow commenters to use shortcodes in comments:
https://wordpress.org/support/topic/jetpack-shotcodes-in-comments-videos/#post-6290792

Embedding images, however, is a bit more complicated as it would mean allowing visitors to upload images to the site. See #143 for a similar request.
A work-around would be to use the Embed shortcode after doing the above.

@jeherve jeherve closed this as completed Nov 20, 2018
@KokkieH
Copy link

KokkieH commented Dec 3, 2018

Reported via https://en.forums.wordpress.com/topic/tweet-embed-in-post-comment/, Tweets also don't auto-embed in comments. The shortcode workaround doesn't appear to work, though - neither the [tweet] shortcode nor the [embed] shortcode causes the tweet to be embedded - instead it just causes a blank comment to appear.

@jeherve
Copy link
Member

jeherve commented Dec 3, 2018

instead it just causes a blank comment to appear.

At this point, I would recommend checking for JS errors on the page to find out more.

@KokkieH
Copy link

KokkieH commented Dec 3, 2018

The shortcodes don't work for me on a test site. Console doesn't show any errors: https://coresandbox.mystagingwebsite.com/2018/10/162/

(First blank comment uses the tweet shortcode, and second uses embed.)

@jeherve
Copy link
Member

jeherve commented Dec 3, 2018

Do you experience the same issue when deactivating the Shortcodes embed and the Comments module, and then trying to publish a new comment?

@KokkieH
Copy link

KokkieH commented Dec 3, 2018

If I disable Jetpack comments and Jetpack shortcode embeds, and also remove the code snippets from your forum thread, I see this:

my_core_sandbox

With that custom code added, but the Jetpack modules disabled, I see:

my_core_sandbox

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Shortcodes / Embeds [Pri] Low and removed [Closed] Won't Fix wontfix. This issue will not be addressed. labels Dec 3, 2018
@jeherve
Copy link
Member

jeherve commented Dec 3, 2018

the [tweet] shortcode won't work here without any modifications, since Jetpack does not bring the shortcode to comments. We've only done that for vimeo and youtube shortcodes.

On WordPress.com, however, it seems we've added support to many more shortcodes. I'll reopen this issue so we can see about bringing this to Jetpack. See r130915-wpcom for more info.

@jeherve jeherve reopened this Dec 3, 2018
@stale
Copy link

stale bot commented Jun 1, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Jun 1, 2019
@eduardozulian
Copy link
Member

Another report for Twitter embeds in comments: 2415009-zen

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 11, 2019
@stale stale bot removed the [Status] Stale label Oct 11, 2019
@stale
Copy link

stale bot commented Apr 8, 2020

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Apr 8, 2020
@joweber123
Copy link
Contributor

Another report of wanting embed capabilities on Atomic sites - #3035740-zd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Shortcodes / Embeds [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

6 participants