Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible block(s?) with latest Gutenberg trunk: Site editor crashes #40055

Closed
dereksmart opened this issue Nov 5, 2024 · 4 comments
Closed
Assignees
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] BLOCKER [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dereksmart
Copy link
Member

dereksmart commented Nov 5, 2024

Impacted plugin

Jetpack

Quick summary

Some changes were made in WordPress/gutenberg#63401 that causes one or some of the Jetpack blocks to crash the site editor.

Honestly I'm not sure if it's a bug with how Jetpack is registering blocks, or if there needs to be more defensive code in Gutenberg. I'm having trouble tracking down the specific block that is causing the error to get minimal reproduction steps.

Steps to reproduce

  1. Activate the Jetpack plugin
  2. Checkout and build gutenberg commit 48341a1
  3. Visit /wp-admin/site-editor.php

A clear and concise description of what you expected to happen.

No crash.

What actually happened

Blank page. With console error

Image

process-block-type.js:153 Uncaught TypeError: Cannot set property supports of #<Object> which has only a getter
    at process-block-type.js:153:25
    at Array.map (<anonymous>)
    at process-block-type.js:151:46
    at thunk-middleware.js:4:11
    at index.js:24:12
    at promise-middleware.js:20:9
    at Object.dispatch (resolvers-cache-middleware.js:45:10)
    at Object.apply (index.js:228:12)
    at private-actions.js:34:30
    at thunk-middleware.js:4:11

Impact

All

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Turn off Jetpack Blocks module.

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

No response

@dereksmart dereksmart added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Nov 5, 2024
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal labels Nov 5, 2024
@jeherve jeherve added [Pri] BLOCKER [Focus] Compatibility Ensuring our products play well with third-parties [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Triaged and removed [Pri] Normal Needs triage Ticket needs to be triaged labels Nov 5, 2024
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Nov 5, 2024
@matticbot matticbot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Nov 5, 2024
@jeherve
Copy link
Member

jeherve commented Nov 5, 2024

@Automattic/jetpack-vulcan Is that something you could check? This is something we'll need to fix (or report to the Gutenberg plugin) before the next Gutenberg release.

Thank you!

@coder-karen
Copy link
Contributor

coder-karen commented Nov 7, 2024

I've created a PR to fix the issue from our end (the issue being related to the behavior of the object that the supports property is exported in), but it would still affect anyone with an older version of Jetpack. I've left a comment on the Gutenberg PR to see if something can be put in place as this would likely affect other plugins too.

@andrewserong
Copy link
Member

A fix has landed in Gutenberg trunk: WordPress/gutenberg#66849 (thanks again @coder-karen for flagging!)

I believe that covers the issue reported here, but please open another issue in Gutenberg if anyone encounters any further issues!

@coder-karen
Copy link
Contributor

Thanks again @andrewserong for the fix! Also thank you @dereksmart for spotting and reporting the breakage as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] BLOCKER [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
5 participants