-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Add WordPress.com integrations to the block editor #12070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick first pass.
0bfded6
to
a529ad4
Compare
Looks like this needs a rebase now. |
84f4957
to
fde9a6e
Compare
@jeherve Could you give this another look when you get a chance? |
9e0d725
to
3506dc4
Compare
3506dc4
to
8070891
Compare
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 7, 2019. |
Thanks for testing! I can see the same errors while testing the WP Admin block editor on Jetpack master. The Calypso JS errors are also present on my local environment while testing other WordPress.com sites. So definitely not related to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, although I think this could benefit from a rebase, some of those commits should not be here.
Fixes Automattic/wp-calypso#32044.
Background: p3fqKv-6Hh-p2.
Changes proposed in this Pull Request:
Load the scripts of the WordPress.com block editor integrations that enhances the block editor with the features available in WordPress.com sites
Calypso Iframed block editor:
WP Admin block editor (also included in the iframed block editor):
Testing instructions:
update/me-sites-version
branch (Sites: Bump/me/sites
API version to 1.3. wp-calypso#32527)./block-editor/post/:yourJetpackDomain
.:yourJetpackDomain/wp-admin/post-new.php
.Proposed changelog entry for your changes:
I guess it's not needed?