Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ia): cleanup settings #3641

Merged
merged 11 commits into from
Jan 28, 2025
Merged

feat(ia): cleanup settings #3641

merged 11 commits into from
Jan 28, 2025

Conversation

jaredrethman
Copy link
Collaborator

@jaredrethman jaredrethman commented Dec 19, 2024

All Submissions:

Changes proposed in this Pull Request:

  • Created includes/wizards/newspack/class-syndication-section.php to house (IA) Newspack > Settings > Syndication php logic.
  • Deleted settings and syndication files as they are no longer being used. Removed all references to Newspack\Settings methods.
  • Migrated includes/wizards/class-settings.php 👉 includes/class-syndication.php. Migrated wizard related properties/methods to includes/wizards/newspack/class-syndication-section.php.

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jaredrethman jaredrethman changed the base branch from trunk to epic/ia December 19, 2024 19:11
@jaredrethman jaredrethman changed the title Feat/ia cleanup settings feat(ia): cleanup settings Jan 13, 2025
@miguelpeixe miguelpeixe marked this pull request as ready for review January 28, 2025 14:14
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 28, 2025 14:14
@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Jan 28, 2025
@miguelpeixe miguelpeixe merged commit 5ea2bb7 into epic/ia Jan 28, 2025
8 checks passed
@miguelpeixe miguelpeixe deleted the feat/ia-cleanup_settings branch January 28, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Information Architecture [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants