Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recaptcha): remove modal checkout restriction from v2 #3674

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Jan 14, 2025

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1200550061930446/1209016713141551/f

This PR removes the restriction for modal-checkout from v2 recaptcha, and ensures the necessary captcha logic triggers on woo checkout form.

How to test the changes in this Pull Request:

  1. Enable v2 recaptcha as admin and ensure threshold is at maximum via Google's recaptcha dashboard
  2. As a reader go through regular woo checkout and verify recaptcha triggers and can be completed successfully
  3. Now go through modal checkout and verify nothing has broken there.
  4. Repeat the above steps for:
    • Recaptcha v3
    • Recaptcha disabled

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle requested a review from a team as a code owner January 14, 2025 15:38
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 14, 2025
@chickenn00dle chickenn00dle changed the base branch from trunk to release January 14, 2025 16:42
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 14, 2025
@chickenn00dle chickenn00dle merged commit 66bd2c8 into release Jan 14, 2025
9 checks passed
@chickenn00dle chickenn00dle deleted the hotfix/v2-recaptcha-woo-checkout branch January 14, 2025 21:02
matticbot pushed a commit that referenced this pull request Jan 14, 2025
## [5.11.1](v5.11.0...v5.11.1) (2025-01-14)

### Bug Fixes

* **recaptcha:** remove modal checkout restriction from v2 ([#3674](#3674)) ([66bd2c8](66bd2c8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants