Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reader-revenue): collect transaction fee settings #3697

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix(reader-revenue): collect transaction fee settings #3697

merged 2 commits into from
Jan 30, 2025

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jan 24, 2025 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Fixes issues with the "Collect transaction fee" settings in Reader Revenue.

How to test the changes in this Pull Request:

  1. Install the latest release build on a fresh testing site and complete initial setup + install required Woo extensions
  2. Visit Newspack > Reader Revenue > Payment Methods and connect a payment gateway. Observe that the "Collect transaction fees" section appears but disabled.
Screenshot 2025-01-23 at 5 08 22 PM
  1. As a reader, start a transaction via the Donate block. Proceed to the second screen and observe that the checkbox to cover transaction fees appears in the payment details box, even though it appears disabled in the settings section.
  2. Install the build from this PR and refresh the settings page. Confirm that the settings section now appears enabled, matching the reader-facing state. Also confirm that you can disable and reenable it, and that the reader-facing state always matches the admin state.
  3. Add a custom message in the "custom message" field and save. Confirm that the custom string persists after saving and refreshing the admin page, and that the reader-facing checkbox shows the custom message here, too.
  4. Delete the custom message and save. Confirm that the empty field persists and that the reader-facing checkbox now shows the default message again.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 24, 2025
@dkoo dkoo self-assigned this Jan 24, 2025
@dkoo dkoo requested a review from a team as a code owner January 24, 2025 00:12
@dkoo dkoo mentioned this pull request Jan 24, 2025
Merged
6 tasks
leogermani
leogermani approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 30, 2025
@dkoo dkoo merged commit 28ff2cd into release Jan 30, 2025
8 checks passed
@dkoo dkoo deleted the hotfix/transaction-fee-settings branch January 30, 2025 18:57
@miguelpeixe
Copy link
Member

@dkoo does this prompt an IA change?

@dkoo
Copy link
Contributor Author

dkoo commented Jan 30, 2025

@dkoo does this prompt an IA change?

Ah yes, probably

matticbot pushed a commit that referenced this pull request Jan 30, 2025
@semantic-release-bot
chore(release): 5.12.5 [skip ci]
eac2141 
## [5.12.5](v5.12.4...v5.12.5) (2025-01-30)

### Bug Fixes

* **reader-revenue:** collect transaction fee settings ([#3697](#3697)) ([28ff2cd](28ff2cd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.12.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees

@dkoo dkoo

Labels
Information Architecture released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkoo @miguelpeixe @matticbot @leogermani