Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ia): dashboard header icon background #3703

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The variable being used to render the Newspack icon for the dashboard wizard (--newspack-ui-color-primary) is not available, causing it to appear as a blank square:

image

Removing it allows for the Newspack icon to render the same way for all wizards, which is the new darker blue.

How to test the changes in this Pull Request:

  1. While on epic/ia, confirm that the wizard on "Newspack -> Dashboard" doesn't render the Newspack icon correctly
  2. Checkout this branch, refresh the page and confirm the header renders as expected
  3. Navigate to "Audience -> Setup" and confirm it renders the same

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 27, 2025
@miguelpeixe miguelpeixe self-assigned this Jan 27, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 27, 2025 19:40
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 28, 2025
@miguelpeixe miguelpeixe merged commit 122cecc into epic/ia Jan 29, 2025
10 checks passed
@miguelpeixe miguelpeixe deleted the fix/ia-dashboard-header-icon-bg branch January 29, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Information Architecture [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants