Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skatepark: Templates:Header template part (including mobile) #4313

Closed
scruffian opened this issue Jul 23, 2021 · 3 comments · Fixed by #4354
Closed

Skatepark: Templates:Header template part (including mobile) #4313

scruffian opened this issue Jul 23, 2021 · 3 comments · Fixed by #4354
Assignees
@jffng
Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Milestone
Skatepark

Comments

@scruffian
Copy link
Member

scruffian commented Jul 23, 2021 •
edited by MaggieCabrera
Loading

Desktop:
Screenshot 2021-07-23 at 16 19 41

Mobile:
Screenshot 2021-07-23 at 16 20 25
@scruffian scruffian added the [Theme] Skatepark Automatically generated label for Skatepark. label Jul 23, 2021
@scruffian scruffian added this to the Skatepark milestone Jul 23, 2021
@MaggieCabrera
Copy link
Contributor

@melchoyce the mobile version of the theme wasn't on the Small theme page in figma, I grabbed this from Page Mockups Let us know if that design is not up to date.

@melchoyce
Copy link
Contributor

Good catch, thanks!

@melchoyce
Copy link
Contributor

Moved the mobile mocks over to the Small Theme page and double-checked all the spacing

@jffng jffng self-assigned this Aug 2, 2021
@jffng jffng mentioned this issue Aug 2, 2021
Merged
@jffng jffng linked a pull request Aug 3, 2021 that will close this issue
Skatepark: add the header #4354
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jffng jffng

Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Projects
None yet
Milestone
Skatepark
Development

Successfully merging a pull request may close this issue.

Skatepark: add the header Automattic/themes
4 participants
@scruffian @melchoyce @MaggieCabrera @jffng