Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geologist: enhancements and code quality #4531

Closed
MaggieCabrera opened this issue Sep 6, 2021 · 2 comments
Closed

Geologist: enhancements and code quality #4531

MaggieCabrera opened this issue Sep 6, 2021 · 2 comments
Assignees
Milestone

Comments

@MaggieCabrera
Copy link
Contributor

After a bit of discussion on slack with @scruffian there's a few things we can polish for Geologist. Right now the theme is directly duplicating Quadrat's css and that could be improved. There's three immediate areas we could work on:

  • The header styling could live in Blockbase by unifying these themes header styles.
  • The buttons styles for Skatepark and Quadrat+Geologist are a design pattern that is very popular. We could include that css in Blockbase without importing it to the main stylesheet, so that the parent theme provides the possibility to import these button styles without adding to the original theme's stylesheet.
  • We should remove the Quadrat block pattern's CSS that is unused in Geologist. @kjellr will Geologist have patterns of its own?
@kjellr
Copy link
Contributor

kjellr commented Sep 7, 2021

We should remove the Quadrat block pattern's CSS that is unused in Geologist. @kjellr will Geologist have patterns of its own?

It probably will, but we haven't designed them yet. I'll add it to my todo list. 👍

@MaggieCabrera
Copy link
Contributor Author

I'm closing this, since the only thing left is the header issue and that is being tracked already

@jeffikus jeffikus added this to the Geologist milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants