Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrawl: Galleries in posts created in Gutenberg display incorrectly #596

Closed
thesacredpath opened this issue Feb 13, 2019 · 2 comments
Closed
Assignees
Labels
[Pri] Low Support [Type] Bug Something isn't working

Comments

@thesacredpath
Copy link

thesacredpath commented Feb 13, 2019

Steps to replicate

In Scrawl, when galleries are put into posts and pages in Calypso or the Classic editor, the galleries extend out past the left and right margins of the theme so that the galleries are larger. When a gallery block and gallery are used in Gutenberg, the gallery images are pulled to the left, but not to the right, so the gallery aligns with the right edge of the content area, and outside of the left content area margin.

CSS that is pulling Gutenberg galleries outside left margin:

.tiled-gallery-wrapper, .jetpack-video-wrapper, img.size-big, .wp-caption.size-big { margin-left: -158px; }

Screenshot from user's NYC Part 1.. post: https://cloudup.com/cbNjwG88VF

Example from Scrawl classic/calypso post: https://scrawldemo.wordpress.com/ (scroll down to Bold Color)

  1. In Scrawl and Gutenberg editor, add gallery block and some images with captions (3?).
  2. Add some text above or below that covers out to margins on content are for reference.
  3. Preview post, or publish and then view on single post or blog page.
  4. Gallery shifted outside left content margin, but not to outside of right content margin.

Expected

Expect that galleries created with Gutenberg would show the same as those created in Calypso or Classic editor.

  • User report: #10380274-hc
  • Follow-up ticket: #1799004-zen
@alaczek alaczek added [Type] Bug Something isn't working Support [Pri] High labels Feb 13, 2019
@alaczek
Copy link
Contributor

alaczek commented Feb 13, 2019

I removed the full URLs. There's a browser script that you can install, that turns HC, ZD, and many other internal URLs into actual link, so there's no need to post full URLs on GH :)

@alaczek alaczek self-assigned this Feb 14, 2019
@alaczek
Copy link
Contributor

alaczek commented Feb 15, 2019

Done in r53382-wpcom-themes. The images and galleries added with the new editor should now behave the same way as those added with the classic editor:

  • galleries will be outdented
  • images wider then 1000px will be outdented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Low Support [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants