-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to React 17 #825
Comments
Do you folks load a different version of React than what ships with WordPress? Currently react should be loaded as an external within the WP environment? From my perspective we should monitor what happens in the Gutenberg project (which will be the signal for when it will potentially land in WordPress core too). Some suggested steps:
The interesting thing from my perspective is that when React 17 drops in WordPress core, there likely will be this awkward period where supporting multiple versions of WordPress means also supporting multiple versions of React. Hopefully that won't be problematic (from what I've seen it shouldn't be). Specific to WooCommerce payments, you might have a different approach than the above if you use React directly in some contexts, but thought I'd share anyways for relevance to the larger coordination between teams using React. |
We do not load another version of React in wc-admin iirc - we instead inherit from WP core. |
There is an open PR for this in the |
WCA PR has been merged, unblocking this one. |
We are already on react 17. Closing this issue as resolved. Please don't hesitate to reopen it if you think that we have more work to do. |
Needs coordination with https://github.com/woocommerce/woocommerce-admin
Timeframe unspecified
cc @timmyc @nerrad
The text was updated successfully, but these errors were encountered: