Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 17 #825

Closed
allendav opened this issue Aug 17, 2020 · 5 comments
Closed

Update to React 17 #825

allendav opened this issue Aug 17, 2020 · 5 comments
Labels
category: engineering For product engineering, architecture work, tech debt and so on. dependencies Pull requests that update a dependency file

Comments

@allendav
Copy link
Contributor

Needs coordination with https://github.com/woocommerce/woocommerce-admin

Timeframe unspecified

cc @timmyc @nerrad

@nerrad
Copy link

nerrad commented Aug 18, 2020

Do you folks load a different version of React than what ships with WordPress? Currently react should be loaded as an external within the WP environment? From my perspective we should monitor what happens in the Gutenberg project (which will be the signal for when it will potentially land in WordPress core too).

Some suggested steps:

  • Watch the Gutenberg issue for when GB has updated it's packages to run React 17 (likely won't happen completely until React 17 stable drops).
  • When those updates land in the GB feature plugin, test with the feature plugin active against our projects (which should start using the new version of React with GB active) and address any issues that pop up.

The interesting thing from my perspective is that when React 17 drops in WordPress core, there likely will be this awkward period where supporting multiple versions of WordPress means also supporting multiple versions of React. Hopefully that won't be problematic (from what I've seen it shouldn't be).

Specific to WooCommerce payments, you might have a different approach than the above if you use React directly in some contexts, but thought I'd share anyways for relevance to the larger coordination between teams using React.

@timmyc
Copy link

timmyc commented Aug 18, 2020

We do not load another version of React in wc-admin iirc - we instead inherit from WP core.

@deepakpathania
Copy link
Contributor

There is an open PR for this in the woocomerce-admin repo now. We can pick this up once that gets merged.

@deepakpathania deepakpathania added category: engineering For product engineering, architecture work, tech debt and so on. dependencies Pull requests that update a dependency file status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. labels Feb 15, 2022
@vbelolapotkov
Copy link
Collaborator

WCA PR has been merged, unblocking this one.

@vbelolapotkov vbelolapotkov added needs prioritisation Triage finished and issues are ready for the following processing. and removed status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. needs prioritisation Triage finished and issues are ready for the following processing. labels May 30, 2022
@zmaglica
Copy link
Contributor

We are already on react 17. Closing this issue as resolved. Please don't hesitate to reopen it if you think that we have more work to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engineering For product engineering, architecture work, tech debt and so on. dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

6 participants