Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: image size feature does nothing #43197

Closed
cecilearkay opened this issue Jun 11, 2020 · 14 comments
Closed

Image block: image size feature does nothing #43197

cecilearkay opened this issue Jun 11, 2020 · 14 comments
Assignees
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Impact] High [Pri] Normal Schedule for the next available opportuinity. [Status] Blocked / Hold [Type] Bug

Comments

@cecilearkay
Copy link

cecilearkay commented Jun 11, 2020

The Image size feature of the Image block doesn't seem to work on WordPress.com. It works fine on self-hosted.

Steps to reproduce

  1. Add an Image block with an image
  2. Choose a size in the dropdown for Image size
  3. Notice it does nothing

What I expected

The image to adapt to the size I chose.

What happened instead

Nothing.

Screenshot / Video

Screen Shot on 2020-06-11 at 15:37:58

EDIT: It was reported in 3039744-zd

@cecilearkay cecilearkay added the [Feature] Media The media screen in Calypso, general media management, or integration with third party media. label Jun 11, 2020
@tanjoymor
Copy link

tanjoymor commented Jun 12, 2020

I was able to reproduce this in various themes: Hever, Scrawl and Gazette

Selecting the image block and then using the blue marker dots to resize the image does work as a work around: https://d.pr/i/3w9em0

@tbradsha
Copy link
Contributor

tbradsha commented Jun 12, 2020

Same issue in 3058622-zen; confirmed on my test site.

For me, both the "Image size" dropdown and the "Image dimensions" height/width settings seem to adjust when within the editor, but they aren't reflected on the live site.

@kaitohm
Copy link

kaitohm commented Jun 13, 2020

Another user report: 21672507-hc --> 3059202-zen

Site is Atomic, using the Arcane theme. Size settings in the block do not change the block in either the editor or the front-end of the site.

@kaitohm
Copy link

kaitohm commented Jun 13, 2020

Another user report: 21845661-hc

Simple site on Soho theme where changing image sizes does not work. In fact, the image size code conflicts with theme styling, making it impossible to set an image to alignfull. Manually removing the image size class in the block code makes alignfull possible.

(The above user interaction has a screen recording of showing this workaround to the user.)

@zdenys
Copy link
Contributor

zdenys commented Jun 13, 2020

I had a related case involving Floral theme (retired premium) and initially, I thought it was about Image Block p1591890840110400-slack-CS108SDLZ but seems to be theme specific so it's reported here 3092-wpcom-premium-themes I remember they mentioned that changing Image size did nothing indeed, so exactly as described above.

Up until 2 weeks ago, setting the Image Block to Full Width in the Editor, the user got the full view like this ​https://d.pr/i/iqORQF but now it’s not working anymore and they see it like this ​https://d.pr/i/GTNGjy
Adding the alignfull class (as per this ​https://wordpress.com/support/adding-additional-css-classes-to-blocks/#make-use-of-existing-custom-css-classes) to each image fixes the issue

@zdenys
Copy link
Contributor

zdenys commented Jun 16, 2020

After some more testing, I can see the issue on a fresh install of https://jurassic.ninja/ + latest Gutenberg Plugin. Here's the screencast: https://d.pr/v/cOXxJF

On https://jurassic.ninja/ site without Gutenberg Plugin the Image Block has no issues: https://d.pr/v/jEUheH

I haven't had the time to check if it's reported at https://github.com/WordPress/gutenberg yet but should be reported there to be fixed.

EDIT: Found this issue reported for Gutenberg plugin: WordPress/gutenberg#21681 So it should be fixed there first.

@zdenys
Copy link
Contributor

zdenys commented Jun 16, 2020

Another case: 3063194-zen (where we need to follow-up after the fix).

I started a Slack thread p1592331141054500-slack-CBTN58FTJ to see if it can be prioritized.

@retnonindya
Copy link

Another report: #21990733-HC

The user also reported slowness on the editor, and they wondered if the editor slowness has anything to do with this issue.

@supernovia
Copy link
Contributor

supernovia commented Jun 18, 2020

Another here:
https://wordpress.com/forums/topic/image-size-drop-down-menu-does-nothing/#post-3512978

Also do we know if this is happening in Gutenberg itself?

edit: can confirm this does not happen on my .org instance currently.
edit again: wrong paste!
edit again again: I just realized the Gutenberg plugin was off on my test site. :)

@razvanpapadopol
Copy link

The user also reported slowness on the editor, and they wondered if the editor slowness has anything to do with this issue.

This issue has nothing to do with the slowness issue which have been solved by Coblocks patch release 2.0.1. p9F6qB-5ok#comment-30161

Also do we know if this is happening in Gutenberg itself?

Yes and the proposed fix in Gutenberg has been merged and it will be included in the next Gutenberg release.

@razvanpapadopol
Copy link

razvanpapadopol commented Jun 22, 2020

On hold until Gutenberg 8.4 is deployed on WordPress.com.

Issue to track the Gutenberg update: #43525

@jeyip jeyip added the [Pri] Normal Schedule for the next available opportuinity. label Jun 23, 2020
@zyousafi
Copy link

Another user report here #18727906-hc

I suggested disabling the Gutenberg plugin and directed the user to the WP-Admin editor. When using the editor there, they have no problems with the resizing when using the Image Block

@tellyworth
Copy link
Contributor

I can reproduce this with Twenty Twenty and the Photos themes.

Additionally, the "Image Dimensions" settings don't seem to allow for an image larger than 640px wide. Even if I manually enter a width and height of say 1024 x 768, I get a 580px image in the post. This is with a jpeg that is 2400x1600.

This is pretty catastrophic for photoblogging. Here's a sample screenshot of a recent post on my blog, with the largest image I can insert:

Screen Shot 2020-08-05 at 2 59 36 pm

(Is this the same issue or should I report it separately?)

@yansern
Copy link
Contributor

yansern commented Aug 5, 2020

This is now fixed for Gutenberg >= 8.4.0. Production is still on 8.3.0. Won't be long for the new release to roll in.
WordPress/gutenberg#23342

@yansern yansern closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Impact] High [Pri] Normal Schedule for the next available opportuinity. [Status] Blocked / Hold [Type] Bug
Projects
None yet
Development

No branches or pull requests