Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Preview: the Activate button needs a loading state #82882

Closed
3 tasks done
autumnfjeld opened this issue Oct 11, 2023 · 2 comments
Closed
3 tasks done

Live Preview: the Activate button needs a loading state #82882

autumnfjeld opened this issue Oct 11, 2023 · 2 comments
Assignees
@arthur791004

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Oct 11, 2023 •
edited by arthur791004
Loading

Description

p1697021447739469-slack-CRWCHQGUB
There is this issue where when activating a previewed theme from the Site Editor, the "Activate" button has no loading state and it can get awkward during the duration of the theme activation.
This is also happening in Core, so it should be a Core issue. I checked the CFT pdtkmj-1JP-p2 and several people had mentioned the issue, so I just wanted to confirm that it's deliberate that we won't fix this for MVP.

Screen.Capture.on.2023-10-11.at.17-46-28.mp4

Image

U02DWV9HXED/F060NBSA2LB-slack-file

Tasks

  • Check in core or with Ignite team or Ben Dwyer if there is already an issue for this
  • If no issue, please create one
  • Contribute fix to core

@Automattic/lego
@scruffian
Copy link
Member

Issue created here: WordPress/gutenberg#55273

@arthur791004
Copy link
Contributor

Closing it via WordPress/gutenberg#55658

@arthur791004 arthur791004 self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthur791004 arthur791004

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scruffian @autumnfjeld @arthur791004