-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hosting Dashboard: Convert the existing “Actions” fields into core DataViews “Actions” #94198
Comments
I started looking at this a little bit. There are a two things that are not possible currently in the Actions API and that exist in the Actions dropdown used in the sites dataviews 1- Descriptions or help text for actions This is probably something we can easily support upstream if needed. 2- Nested drop-down for actions (or "grouping" actions) While I think it's possible to support potentially by introducing some notion of "group" for actions or something like that. I'm not entirely sure we should support it to be honest. My suggestion would be to remove the nesting and maybe have a single link to Hosting where the user can see all these sections. WDYT. @jameskoster @davemart-in |
I think it would be fine to drop both the nested dropdown and the help text. |
For clarity, myr PR is at the moment blocked by the fact that the I know @jsnajdr was looking into iterations on the sites endpoint to address that but it seems a bit complex, so I'm not entirely sure what's the next step here. |
The REST endpoint is fixed, it now returns the active |
Oh I didn't know. Thanks @jsnajdr. Do you think I should wait for your PR to land first or should I update my actions PR (smaller scope) to use the featured directly? Thinking the latter unless you have any reservations |
I won't get to work on it again at least until Oct 2, so you might want to use the Instead of using the hasFeature = ( state, siteId, feature ) => getSite( state, siteId ).plan.features.active.includes( feature ) If the |
Great Thanks, I'll give it a try. |
I think this can be closed now. ✨ |
Convert the existing “Actions” fields into proper core DataViews “Actions”. This means we have bulk selection for free and there’s no table header tools for that column (move left/right controls).
Follow-up to #93503
The text was updated successfully, but these errors were encountered: